Merge pull request #1549 from mfietz/issue/1219-ise-create-options-menu

Prevent IllegalStateException when fragment is detached

app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java

@@ -190,6 +190,9 @@ public class AllEpisodesFragment extends Fragment {
 
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
+        if(!isAdded()) {
+            return;
+        }
         super.onCreateOptionsMenu(menu, inflater);
         if (itemsLoaded) {
             inflater.inflate(R.menu.new_episodes, menu);

app/src/main/java/de/danoeh/antennapod/fragment/DownloadLogFragment.java

@@ -111,6 +111,9 @@ public class DownloadLogFragment extends ListFragment {
 
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
+        if(!isAdded()) {
+            return;
+        }
         super.onCreateOptionsMenu(menu, inflater);
         if (itemsLoaded) {
             MenuItem clearHistory = menu.add(Menu.NONE, R.id.clear_history_item, Menu.CATEGORY_CONTAINER, R.string.clear_history_label);

app/src/main/java/de/danoeh/antennapod/fragment/ItemFragment.java

@@ -243,7 +243,7 @@ public class ItemFragment extends Fragment {
 
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
-        if(item == null) {
+        if(!isAdded() || item == null) {
             return;
         }
         inflater.inflate(R.menu.feeditem_options, menu);

app/src/main/java/de/danoeh/antennapod/fragment/ItemlistFragment.java

@@ -194,6 +194,9 @@ public class ItemlistFragment extends ListFragment {
 
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
+        if(!isAdded()) {
+            return;
+        }
         super.onCreateOptionsMenu(menu, inflater);
 
         if (itemsLoaded) {

app/src/main/java/de/danoeh/antennapod/fragment/PlaybackHistoryFragment.java

@@ -148,6 +148,9 @@ public class PlaybackHistoryFragment extends ListFragment {
 
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
+        if(!isAdded()) {
+            return;
+        }
         super.onCreateOptionsMenu(menu, inflater);
         if (itemsLoaded) {
             MenuItem clearHistory = menu.add(Menu.NONE, R.id.clear_history_item, Menu.CATEGORY_CONTAINER, R.string.clear_history_label);

app/src/main/java/de/danoeh/antennapod/fragment/QueueFragment.java

@@ -235,6 +235,9 @@ public class QueueFragment extends Fragment {
 
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
+        if(!isAdded()) {
+            return;
+        }
         super.onCreateOptionsMenu(menu, inflater);
         if (queue != null) {
             inflater.inflate(R.menu.queue, menu);