test tweak - ensure playback queue updated after download - await for the event explicitly.

This commit is contained in:
orionlee 2019-09-30 12:07:53 -07:00
parent 38e9cafee3
commit cbf6103c00
1 changed files with 24 additions and 2 deletions

View File

@ -5,7 +5,9 @@ import android.support.test.InstrumentationRegistry;
import android.support.test.annotation.UiThreadTest; import android.support.test.annotation.UiThreadTest;
import android.support.test.filters.LargeTest; import android.support.test.filters.LargeTest;
import org.awaitility.Awaitility;
import org.greenrobot.eventbus.EventBus; import org.greenrobot.eventbus.EventBus;
import org.greenrobot.eventbus.Subscribe;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@ -16,6 +18,7 @@ import java.util.List;
import java.util.concurrent.CountDownLatch; import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import de.danoeh.antennapod.core.event.FeedItemEvent;
import de.danoeh.antennapod.core.event.QueueEvent; import de.danoeh.antennapod.core.event.QueueEvent;
import de.danoeh.antennapod.core.feed.EventDistributor; import de.danoeh.antennapod.core.feed.EventDistributor;
import de.danoeh.antennapod.core.feed.Feed; import de.danoeh.antennapod.core.feed.Feed;
@ -146,6 +149,9 @@ public class PlaybackServiceTaskManagerTest {
assertThat("The item is not yet downloaded", assertThat("The item is not yet downloaded",
testItem.getMedia().isDownloaded(), is(false)); testItem.getMedia().isDownloaded(), is(false));
FeedItemEventListener feedItemEventListener = new FeedItemEventListener();
EventBus.getDefault().register(feedItemEventListener);
{ // simulate download complete (in DownloadService.MediaHandlerThread) { // simulate download complete (in DownloadService.MediaHandlerThread)
FeedItem item = DBReader.getFeedItem(testItem.getId()); FeedItem item = DBReader.getFeedItem(testItem.getId());
item.getMedia().setDownloaded(true); item.getMedia().setDownloaded(true);
@ -155,16 +161,32 @@ public class PlaybackServiceTaskManagerTest {
DBWriter.setFeedItem(item).get(); DBWriter.setFeedItem(item).get();
} }
// an approximation to ensure the item update event has been posted and processed. Awaitility.await()
Thread.sleep(10); .atMost(1000, TimeUnit.MILLISECONDS)
.until(() -> feedItemEventListener.getEvents().size() > 0);
final FeedItem itemUpdated = pstm.getQueue().get(0); final FeedItem itemUpdated = pstm.getQueue().get(0);
assertThat("The queue in PlaybackService has been updated item after download is completed", assertThat("The queue in PlaybackService has been updated item after download is completed",
itemUpdated.getMedia().isDownloaded(), is(true)); itemUpdated.getMedia().isDownloaded(), is(true));
EventBus.getDefault().unregister(feedItemEventListener);
pstm.shutdown(); pstm.shutdown();
} }
private static class FeedItemEventListener {
private final List<FeedItemEvent> events = new ArrayList<>();
@Subscribe
public void onEvent(FeedItemEvent event) {
events.add(event);
}
List<? extends FeedItemEvent> getEvents() {
return events;
}
}
@Test @Test
public void testStartPositionSaver() throws InterruptedException { public void testStartPositionSaver() throws InterruptedException {
final Context c = InstrumentationRegistry.getInstrumentation().getTargetContext(); final Context c = InstrumentationRegistry.getInstrumentation().getTargetContext();