Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

#2966 RxJava2 null - case underlying method has needs to return null.

Browse Source 
Need to wrap return result with Optional<>
Mark code path with TODO. Actual fix is pending #2954 merge.

Rx observer: underlying sources that need to return Optional<>
OnlineFeedViewActivity.parseFeed : <anonymous subscriber>
PlaybackController.bindToService : fixed in #2954
This commit is contained in:
orionlee 2019-01-10 12:19:04 -08:00
parent 1655d234af
commit c04f340ae2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/de/danoeh/antennapod/activity/OnlineFeedViewActivity.java
View File

@ -316,6 +316,7 @@ public class OnlineFeedViewActivity extends AppCompatActivity {
Log.d(TAG, "Parsing feed"); Log.d(TAG, "Parsing feed");
parser = Observable.fromCallable(() -> { parser = Observable.fromCallable(() -> {
// TODO: [PENDING 2954] return Optional<FeedHandlerResult>
FeedHandler handler = new FeedHandler(); FeedHandler handler = new FeedHandler();
try { try {
return handler.parseFeed(feed); return handler.parseFeed(feed);
@ -337,7 +338,7 @@ public class OnlineFeedViewActivity extends AppCompatActivity {
}) })
.subscribeOn(Schedulers.computation()) .subscribeOn(Schedulers.computation())
.observeOn(AndroidSchedulers.mainThread()) .observeOn(AndroidSchedulers.mainThread())
.subscribe(result -> { .subscribe(result -> { // TODO: [PENDING 2954] wrap underlying Nullable return with Optional<>
if(result != null) { if(result != null) {
beforeShowFeedInformation(result.feed); beforeShowFeedInformation(result.feed);
showFeedInformation(result.feed, result.alternateFeedUrls); showFeedInformation(result.feed, result.alternateFeedUrls);