Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove catch for exception that is never thrown

Browse Source
This commit is contained in:
Martin Fietz 2018-01-14 18:41:26 +01:00
parent c12fedf392
commit b38d016ec3
6 changed files with 4 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java
View File

@ -284,13 +284,7 @@ public class AllEpisodesFragment extends Fragment {
return super.onContextItemSelected(item); return super.onContextItemSelected(item);
} }
try {
return FeedItemMenuHandler.onMenuItemClicked(getActivity(), item.getItemId(), selectedItem); return FeedItemMenuHandler.onMenuItemClicked(getActivity(), item.getItemId(), selectedItem);
} catch (DownloadRequestException e) {
e.printStackTrace();
Toast.makeText(getActivity(), e.getMessage(), Toast.LENGTH_LONG).show();
return true;
}
} }
@Override @Override

6
app/src/main/java/de/danoeh/antennapod/fragment/ItemFragment.java
View File

@ -334,13 +334,7 @@ public class ItemFragment extends Fragment implements OnSwipeGesture {
openPodcast(); openPodcast();
return true; return true;
default: default:
try {
return FeedItemMenuHandler.onMenuItemClicked(getActivity(), menuItem.getItemId(), item); return FeedItemMenuHandler.onMenuItemClicked(getActivity(), menuItem.getItemId(), item);
} catch (DownloadRequestException e) {
e.printStackTrace();
Toast.makeText(getActivity(), e.getMessage(), Toast.LENGTH_LONG).show();
return true;
}
} }
} }

5
app/src/main/java/de/danoeh/antennapod/fragment/ItemlistFragment.java
View File

@ -340,12 +340,7 @@ public class ItemlistFragment extends ListFragment {
return super.onContextItemSelected(item); return super.onContextItemSelected(item);
} }
try {
return FeedItemMenuHandler.onMenuItemClicked(getActivity(), item.getItemId(), selectedItem); return FeedItemMenuHandler.onMenuItemClicked(getActivity(), item.getItemId(), selectedItem);
} catch (DownloadRequestException e) {
// context menu doesn't contain download functionality
return true;
}
} }
@Override @Override

6
app/src/main/java/de/danoeh/antennapod/fragment/QueueFragment.java
View File

@ -363,13 +363,7 @@ public class QueueFragment extends Fragment {
DBWriter.moveQueueItemToBottom(selectedItem.getId(), true); DBWriter.moveQueueItemToBottom(selectedItem.getId(), true);
return true; return true;
default: default:
try {
return FeedItemMenuHandler.onMenuItemClicked(getActivity(), item.getItemId(), selectedItem); return FeedItemMenuHandler.onMenuItemClicked(getActivity(), item.getItemId(), selectedItem);
} catch (DownloadRequestException e) {
e.printStackTrace();
Toast.makeText(getActivity(), e.getMessage(), Toast.LENGTH_LONG).show();
return true;
}
} }
} }

1
app/src/main/java/de/danoeh/antennapod/menuhandler/FeedItemMenuHandler.java
View File

@ -17,7 +17,6 @@ import de.danoeh.antennapod.core.preferences.UserPreferences;
import de.danoeh.antennapod.core.service.playback.PlaybackService; import de.danoeh.antennapod.core.service.playback.PlaybackService;
import de.danoeh.antennapod.core.storage.DBTasks; import de.danoeh.antennapod.core.storage.DBTasks;
import de.danoeh.antennapod.core.storage.DBWriter; import de.danoeh.antennapod.core.storage.DBWriter;
import de.danoeh.antennapod.core.storage.DownloadRequestException;
import de.danoeh.antennapod.core.util.IntentUtils; import de.danoeh.antennapod.core.util.IntentUtils;
import de.danoeh.antennapod.core.util.LongList; import de.danoeh.antennapod.core.util.LongList;
import de.danoeh.antennapod.core.util.ShareUtils; import de.danoeh.antennapod.core.util.ShareUtils;

2
core/src/main/java/de/danoeh/antennapod/core/service/GpodnetSyncService.java
View File

@ -222,8 +222,6 @@ public class GpodnetSyncService extends Service {
} catch (GpodnetServiceException e) { } catch (GpodnetServiceException e) {
e.printStackTrace(); e.printStackTrace();
updateErrorNotification(e); updateErrorNotification(e);
} catch (DownloadRequestException e) {
e.printStackTrace();
} }
} }