Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not return true in handleKeycode if nothing was done

Browse Source
This commit is contained in:
ByteHamster 2020-02-08 00:12:33 +01:00
parent f790b78b1a
commit aa48cdb14c
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/main/java/de/danoeh/antennapod/core/service/playback/PlaybackService.java
View File

@ -573,6 +573,8 @@ public class PlaybackService extends MediaBrowserServiceCompat {
mediaPlayer.prepare(); mediaPlayer.prepare();
} else if (mediaPlayer.getPlayable() == null) { } else if (mediaPlayer.getPlayable() == null) {
startPlayingFromPreferences(); startPlayingFromPreferences();
} else {
return false;
} }
taskManager.restartSleepTimer(); taskManager.restartSleepTimer();
return true; return true;
@ -584,18 +586,19 @@ public class PlaybackService extends MediaBrowserServiceCompat {
mediaPlayer.prepare(); mediaPlayer.prepare();
} else if (mediaPlayer.getPlayable() == null) { } else if (mediaPlayer.getPlayable() == null) {
startPlayingFromPreferences(); startPlayingFromPreferences();
} else {
return false;
} }
taskManager.restartSleepTimer(); taskManager.restartSleepTimer();
return true; return true;
case KeyEvent.KEYCODE_MEDIA_PAUSE: case KeyEvent.KEYCODE_MEDIA_PAUSE:
if (status == PlayerStatus.PLAYING) { if (status == PlayerStatus.PLAYING) {
mediaPlayer.pause(!UserPreferences.isPersistNotify(), false); mediaPlayer.pause(!UserPreferences.isPersistNotify(), false);
return true;
} }
return false;
return true;
case KeyEvent.KEYCODE_MEDIA_NEXT: case KeyEvent.KEYCODE_MEDIA_NEXT:
if (notificationButton || if (notificationButton || UserPreferences.shouldHardwareButtonSkip()) {
UserPreferences.shouldHardwareButtonSkip()) {
// assume the skip command comes from a notification or the lockscreen // assume the skip command comes from a notification or the lockscreen
// a >| skip button should actually skip // a >| skip button should actually skip
mediaPlayer.skip(); mediaPlayer.skip();