From a16f2d2124f12e4c0a46afdbb588baa959983048 Mon Sep 17 00:00:00 2001 From: Martin Fietz Date: Wed, 1 Jun 2016 12:13:13 +0200 Subject: [PATCH 1/2] New episodes: Mark all as seen instead of played --- .../antennapod/fragment/AllEpisodesFragment.java | 14 ++++++++------ .../antennapod/fragment/NewEpisodesFragment.java | 2 ++ .../res/menu/{new_episodes.xml => episodes.xml} | 9 ++++++++- core/src/main/res/values/strings.xml | 1 + 4 files changed, 19 insertions(+), 7 deletions(-) rename app/src/main/res/menu/{new_episodes.xml => episodes.xml} (77%) diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java index 8ae7f1cf9..37fb4ca4f 100644 --- a/app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/fragment/AllEpisodesFragment.java @@ -180,7 +180,7 @@ public class AllEpisodesFragment extends Fragment { } super.onCreateOptionsMenu(menu, inflater); if (itemsLoaded) { - inflater.inflate(R.menu.new_episodes, menu); + inflater.inflate(R.menu.episodes, menu); MenuItem searchItem = menu.findItem(R.id.action_search); final SearchView sv = (SearchView) MenuItemCompat.getActionView(searchItem); @@ -206,11 +206,13 @@ public class AllEpisodesFragment extends Fragment { @Override public void onPrepareOptionsMenu(Menu menu) { super.onPrepareOptionsMenu(menu); - if (itemsLoaded) { - MenuItem menuItem = menu.findItem(R.id.mark_all_read_item); - if (menuItem != null) { - menuItem.setVisible(episodes != null && !episodes.isEmpty()); - } + MenuItem markAllRead = menu.findItem(R.id.mark_all_read_item); + if (markAllRead != null) { + markAllRead.setVisible(!showOnlyNewEpisodes() && episodes != null && !episodes.isEmpty()); + } + MenuItem markAllSeen = menu.findItem(R.id.mark_all_seen_item); + if(markAllSeen != null) { + markAllSeen.setVisible(showOnlyNewEpisodes() && episodes != null && !episodes.isEmpty()); } } diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java index 7ef070f21..8f786eb46 100644 --- a/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java @@ -7,6 +7,8 @@ import android.support.v7.widget.RecyclerView; import android.support.v7.widget.helper.ItemTouchHelper; import android.util.Log; import android.view.LayoutInflater; +import android.view.Menu; +import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; diff --git a/app/src/main/res/menu/new_episodes.xml b/app/src/main/res/menu/episodes.xml similarity index 77% rename from app/src/main/res/menu/new_episodes.xml rename to app/src/main/res/menu/episodes.xml index 1e1d7ab78..bbaabcd8b 100644 --- a/app/src/main/res/menu/new_episodes.xml +++ b/app/src/main/res/menu/episodes.xml @@ -24,4 +24,11 @@ custom:showAsAction="collapseActionView" android:icon="?attr/navigation_accept"/> - \ No newline at end of file + + + diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml index 7e0982294..620bc2b65 100644 --- a/core/src/main/res/values/strings.xml +++ b/core/src/main/res/values/strings.xml @@ -143,6 +143,7 @@ Stream Remove Remove Episode + Marked as seen Mark as played Marked as played Mark as unplayed From de09c275a90a31a7a885907a20c3970cbbb0aca5 Mon Sep 17 00:00:00 2001 From: Martin Fietz Date: Wed, 1 Jun 2016 12:14:12 +0200 Subject: [PATCH 2/2] New episodes: Show correct snackbar "marked as seen" --- .../java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java index 8f786eb46..183c10f3d 100644 --- a/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java +++ b/app/src/main/java/de/danoeh/antennapod/fragment/NewEpisodesFragment.java @@ -94,7 +94,7 @@ public class NewEpisodesFragment extends AllEpisodesFragment { } }; - Snackbar snackbar = Snackbar.make(root, getString(R.string.marked_as_read_label), + Snackbar snackbar = Snackbar.make(root, getString(R.string.marked_as_seen_label), Snackbar.LENGTH_LONG); snackbar.setAction(getString(R.string.undo), v -> { DBWriter.markItemPlayed(FeedItem.NEW, item.getId());