Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

#3248 Review findings

Browse Source
This commit is contained in:
Max Bechtold 2019-07-15 11:56:06 +02:00
parent aa4d3bde94
commit 7f0e642069
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/de/danoeh/antennapod/fragment/FeedSettingsFragment.java
View File

@ -43,7 +43,7 @@ public class FeedSettingsFragment extends PreferenceFragmentCompat {
setupEpisodeFilterPreference(); setupEpisodeFilterPreference();
updateAutoDeleteSummary(); updateAutoDeleteSummary();
updateVolumeReductionSummary(); updateVolumeReductionValue();
updateAutoDownloadEnabled(); updateAutoDownloadEnabled();
}).dispose(); }).dispose();
} }
@ -131,13 +131,13 @@ public class FeedSettingsFragment extends PreferenceFragmentCompat {
break; break;
} }
feed.savePreferences(); feed.savePreferences();
updateVolumeReductionSummary(); updateVolumeReductionValue();
// TODO maxbechtold Check if we can call setVolume for the PlaybackService, if running. Else, show toast? // TODO maxbechtold Check if we can call setVolume for the PlaybackService, if running. Else, show toast?
return false; return false;
}); });
} }
private void updateVolumeReductionSummary() { private void updateVolumeReductionValue() {
ListPreference volumeReductionPreference = (ListPreference) findPreference("volumeReduction"); ListPreference volumeReductionPreference = (ListPreference) findPreference("volumeReduction");
switch (feedPreferences.getVolumeReductionSetting()) { switch (feedPreferences.getVolumeReductionSetting()) {

3
core/src/test/java/de/danoeh/antennapod/core/service/playback/FeedVolumeReductionTest.java
View File

@ -3,7 +3,8 @@ package de.danoeh.antennapod.core.service.playback;
import de.danoeh.antennapod.core.feed.FeedPreferences; import de.danoeh.antennapod.core.feed.FeedPreferences;
import org.junit.Test; import org.junit.Test;
import static org.junit.Assert.*; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;