Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use constants instead hardcoded numbers in view pagers adapters

Browse Source
This commit is contained in:
Ebrahim Byagowi 2020-04-10 14:18:40 +04:30
parent 965fc5c27d
commit 75e9ee9e0d
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/src/main/java/de/danoeh/antennapod/fragment/EpisodesFragment.java
View File

@ -57,12 +57,12 @@ public class EpisodesFragment extends Fragment {
new TabLayoutMediator(tabLayout, viewPager, (tab, position) -> { new TabLayoutMediator(tabLayout, viewPager, (tab, position) -> {
switch (position) { switch (position) {
case POS_ALL_EPISODES:
tab.setText(R.string.all_episodes_short_label);
break;
case POS_NEW_EPISODES: case POS_NEW_EPISODES:
tab.setText(R.string.new_episodes_label); tab.setText(R.string.new_episodes_label);
break; break;
case POS_ALL_EPISODES:
tab.setText(R.string.all_episodes_short_label);
break;
case POS_FAV_EPISODES: case POS_FAV_EPISODES:
tab.setText(R.string.favorite_episodes_label); tab.setText(R.string.favorite_episodes_label);
break; break;
@ -94,7 +94,7 @@ public class EpisodesFragment extends Fragment {
viewPager.setCurrentItem(lastPosition); viewPager.setCurrentItem(lastPosition);
} }
public class EpisodesPagerAdapter extends FragmentStateAdapter { static class EpisodesPagerAdapter extends FragmentStateAdapter {
EpisodesPagerAdapter(@NonNull Fragment fragment) { EpisodesPagerAdapter(@NonNull Fragment fragment) {
super(fragment); super(fragment);
@ -104,11 +104,12 @@ public class EpisodesFragment extends Fragment {
@Override @Override
public Fragment createFragment(int position) { public Fragment createFragment(int position) {
switch (position) { switch (position) {
case 0: case POS_NEW_EPISODES:
return new NewEpisodesFragment(); return new NewEpisodesFragment();
case 1: case POS_ALL_EPISODES:
return new AllEpisodesFragment(); return new AllEpisodesFragment();
default: default:
case POS_FAV_EPISODES:
return new FavoriteEpisodesFragment(); return new FavoriteEpisodesFragment();
} }
} }

4
app/src/main/java/de/danoeh/antennapod/fragment/preferences/StatisticsFragment.java
View File

@ -80,10 +80,10 @@ public class StatisticsFragment extends Fragment {
@Override @Override
public Fragment createFragment(int position) { public Fragment createFragment(int position) {
switch (position) { switch (position) {
case 0: case POS_LISTENED_HOURS:
return new PlaybackStatisticsFragment(); return new PlaybackStatisticsFragment();
default: default:
case 1: case POS_SPACE_TAKEN:
return new DownloadStatisticsFragment(); return new DownloadStatisticsFragment();
} }
} }