Castopod
/
AntennaPod
mirror of https://github.com/AntennaPod/AntennaPod.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix IDE warnings 

Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
This commit is contained in:
Anderson Mesquita 2019-05-25 13:30:37 -04:00
parent 56dc16802a
commit 69f116904d
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
app/src/main/java/de/danoeh/antennapod/fragment/CompletedDownloadsFragment.java
View File

@ -2,6 +2,7 @@ package de.danoeh.antennapod.fragment;
import android.content.Context; import android.content.Context;
import android.os.Bundle; import android.os.Bundle;
import android.support.annotation.NonNull;
import android.support.v4.app.ListFragment; import android.support.v4.app.ListFragment;
import android.util.Log; import android.util.Log;
import android.view.Menu; import android.view.Menu;
@ -27,6 +28,9 @@ import io.reactivex.android.schedulers.AndroidSchedulers;
import io.reactivex.disposables.Disposable; import io.reactivex.disposables.Disposable;
import io.reactivex.schedulers.Schedulers; import io.reactivex.schedulers.Schedulers;
import static de.danoeh.antennapod.dialog.EpisodesApplyActionFragment.ACTION_ADD_TO_QUEUE;
import static de.danoeh.antennapod.dialog.EpisodesApplyActionFragment.ACTION_DELETE;
/** /**
* Displays all running downloads and provides a button to delete them * Displays all running downloads and provides a button to delete them
*/ */
@ -94,7 +98,7 @@ public class CompletedDownloadsFragment extends ListFragment {
} }
@Override @Override
public void onViewCreated(View view, Bundle savedInstanceState) { public void onViewCreated(@NonNull View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState); super.onViewCreated(view, savedInstanceState);
// add padding // add padding
@ -119,7 +123,7 @@ public class CompletedDownloadsFragment extends ListFragment {
super.onListItemClick(l, v, position, id); super.onListItemClick(l, v, position, id);
position -= l.getHeaderViewsCount(); position -= l.getHeaderViewsCount();
long[] ids = FeedItemUtil.getIds(items); long[] ids = FeedItemUtil.getIds(items);
((MainActivity) getActivity()).loadChildFragment(ItemFragment.newInstance(ids, position)); ((MainActivity) requireActivity()).loadChildFragment(ItemFragment.newInstance(ids, position));
} }
private void onFragmentLoaded() { private void onFragmentLoaded() {
@ -129,7 +133,7 @@ public class CompletedDownloadsFragment extends ListFragment {
} }
setListShown(true); setListShown(true);
listAdapter.notifyDataSetChanged(); listAdapter.notifyDataSetChanged();
getActivity().supportInvalidateOptionsMenu(); requireActivity().invalidateOptionsMenu();
} }
@Override @Override
@ -146,15 +150,12 @@ public class CompletedDownloadsFragment extends ListFragment {
@Override @Override
public boolean onOptionsItemSelected(MenuItem item) { public boolean onOptionsItemSelected(MenuItem item) {
switch (item.getItemId()) { if (item.getItemId() == R.id.episode_actions) {
case R.id.episode_actions: ((MainActivity) requireActivity())
EpisodesApplyActionFragment fragment = EpisodesApplyActionFragment .loadChildFragment(EpisodesApplyActionFragment.newInstance(items, ACTION_DELETE | ACTION_ADD_TO_QUEUE));
.newInstance(items, EpisodesApplyActionFragment.ACTION_DELETE | EpisodesApplyActionFragment.ACTION_ADD_TO_QUEUE); return true;
((MainActivity) getActivity()).loadChildFragment(fragment);
return true;
default:
return false;
} }
return false;
} }
private final DownloadedEpisodesListAdapter.ItemAccess itemAccess = new DownloadedEpisodesListAdapter.ItemAccess() { private final DownloadedEpisodesListAdapter.ItemAccess itemAccess = new DownloadedEpisodesListAdapter.ItemAccess() {
@ -174,7 +175,7 @@ public class CompletedDownloadsFragment extends ListFragment {
@Override @Override
public void onFeedItemSecondaryAction(FeedItem item) { public void onFeedItemSecondaryAction(FeedItem item) {
DBWriter.deleteFeedMediaOfItem(getActivity(), item.getMedia().getId()); DBWriter.deleteFeedMediaOfItem(requireActivity(), item.getMedia().getId());
} }
}; };