From 2e38cf3a40abb7ad18ea58b61c12450e69ab84fa Mon Sep 17 00:00:00 2001 From: orionlee Date: Thu, 3 May 2018 14:00:48 -0700 Subject: [PATCH 1/3] Build tweak: Speed up debug build by making dexcount optional in debug build, configured with a new gradle property enableDexcountInDebug. --- app/build.gradle | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index e4f66fe64..0efe9df73 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -83,7 +83,14 @@ android { applicationIdSuffix ".debug" resValue "string", "provider_authority", "de.danoeh.antennapod.debug.provider" buildConfigField STRING, FLATTR_APP_KEY, mFlattrAppKey - buildConfigField STRING, FLATTR_APP_SECRET, mFlattrAppSecret + buildConfigField STRING, FLATTR_APP_SECRET, mFlattrAppSecret + dexcount { + // Optionally, can disable Dexcount by setting the property + // in gradle.properties file or via -P command line argument. + if (project.hasProperty("enableDexcountInDebug")) { + runOnEachPackage enableDexcountInDebug.toBoolean() + } // else default to true + } } release { resValue "string", "provider_authority", "de.danoeh.antennapod.provider" From 4d4b1f9c1785a1f4fa5beb979b8c0dd1760723f6 Mon Sep 17 00:00:00 2001 From: orionlee Date: Sun, 13 May 2018 15:07:07 -0700 Subject: [PATCH 2/3] make dexCount defaulted to disabled in debug build per reveiw feedback --- app/build.gradle | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index 0efe9df73..fd6f8dd05 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -89,7 +89,9 @@ android { // in gradle.properties file or via -P command line argument. if (project.hasProperty("enableDexcountInDebug")) { runOnEachPackage enableDexcountInDebug.toBoolean() - } // else default to true + } else { // default to not running dexcount + runOnEachPackage false + } } } release { From 0f1dfd05479fc4d52628cd6963b8849650632a57 Mon Sep 17 00:00:00 2001 From: orionlee Date: Mon, 14 May 2018 10:55:47 -0700 Subject: [PATCH 3/3] dexcount: remove dated comments --- app/build.gradle | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index fd6f8dd05..0d66a80c3 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -85,8 +85,6 @@ android { buildConfigField STRING, FLATTR_APP_KEY, mFlattrAppKey buildConfigField STRING, FLATTR_APP_SECRET, mFlattrAppSecret dexcount { - // Optionally, can disable Dexcount by setting the property - // in gradle.properties file or via -P command line argument. if (project.hasProperty("enableDexcountInDebug")) { runOnEachPackage enableDexcountInDebug.toBoolean() } else { // default to not running dexcount