Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix menu items duplication in episodes and downloads fragment

Browse Source 
As ViewPager2 different lifecycle apparently setHasOptionsMenu
needs to be called from onResume() from now on.
This commit is contained in:
Ebrahim Byagowi 2020-04-12 12:04:16 +04:30
parent c88336f17f
commit 430e0d403e
3 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/src/main/java/de/danoeh/antennapod/fragment/CompletedDownloadsFragment.java
View File

@ -86,10 +86,15 @@ public class CompletedDownloadsFragment extends Fragment {
@Override
public void onStart() {
super.onStart();
setHasOptionsMenu(true);
loadItems();
}
@Override
public void onResume() {
super.onResume();
setHasOptionsMenu(true);
}
@Override
public void onStop() {
super.onStop();

8
app/src/main/java/de/danoeh/antennapod/fragment/DownloadLogFragment.java
View File

@ -50,6 +50,12 @@ public class DownloadLogFragment extends ListFragment {
loadItems();
}
@Override
public void onResume() {
super.onResume();
setHasOptionsMenu(true);
}
@Override
public void onStop() {
super.onStop();
@ -61,8 +67,6 @@ public class DownloadLogFragment extends ListFragment {
@Override
public void onViewCreated(View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
setHasOptionsMenu(true);
// add padding
final ListView lv = getListView();
lv.setClipToPadding(false);

2
app/src/main/java/de/danoeh/antennapod/fragment/EpisodesListFragment.java
View File

@ -83,7 +83,6 @@ public abstract class EpisodesListFragment extends Fragment {
@Override
public void onStart() {
super.onStart();
setHasOptionsMenu(true);
EventBus.getDefault().register(this);
loadItems();
}
@ -91,6 +90,7 @@ public abstract class EpisodesListFragment extends Fragment {
@Override
public void onResume() {
super.onResume();
setHasOptionsMenu(true);
registerForContextMenu(recyclerView);
}