Fix menu items duplication in episodes and downloads fragment

As ViewPager2 different lifecycle apparently setHasOptionsMenu
needs to be called from onResume() from now on.
This commit is contained in:
Ebrahim Byagowi 2020-04-12 12:04:16 +04:30
parent c88336f17f
commit 430e0d403e
3 changed files with 13 additions and 4 deletions

View File

@ -86,10 +86,15 @@ public class CompletedDownloadsFragment extends Fragment {
@Override @Override
public void onStart() { public void onStart() {
super.onStart(); super.onStart();
setHasOptionsMenu(true);
loadItems(); loadItems();
} }
@Override
public void onResume() {
super.onResume();
setHasOptionsMenu(true);
}
@Override @Override
public void onStop() { public void onStop() {
super.onStop(); super.onStop();

View File

@ -50,6 +50,12 @@ public class DownloadLogFragment extends ListFragment {
loadItems(); loadItems();
} }
@Override
public void onResume() {
super.onResume();
setHasOptionsMenu(true);
}
@Override @Override
public void onStop() { public void onStop() {
super.onStop(); super.onStop();
@ -61,8 +67,6 @@ public class DownloadLogFragment extends ListFragment {
@Override @Override
public void onViewCreated(View view, Bundle savedInstanceState) { public void onViewCreated(View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState); super.onViewCreated(view, savedInstanceState);
setHasOptionsMenu(true);
// add padding // add padding
final ListView lv = getListView(); final ListView lv = getListView();
lv.setClipToPadding(false); lv.setClipToPadding(false);

View File

@ -83,7 +83,6 @@ public abstract class EpisodesListFragment extends Fragment {
@Override @Override
public void onStart() { public void onStart() {
super.onStart(); super.onStart();
setHasOptionsMenu(true);
EventBus.getDefault().register(this); EventBus.getDefault().register(this);
loadItems(); loadItems();
} }
@ -91,6 +90,7 @@ public abstract class EpisodesListFragment extends Fragment {
@Override @Override
public void onResume() { public void onResume() {
super.onResume(); super.onResume();
setHasOptionsMenu(true);
registerForContextMenu(recyclerView); registerForContextMenu(recyclerView);
} }