Castopod/AntennaPod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Dispose loaders before setting controller to null

Browse Source
This commit is contained in:
ByteHamster 2020-07-27 13:16:23 +02:00
parent 4ddee03214
commit 426be4d226
3 changed files with 10 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/main/java/de/danoeh/antennapod/fragment/ChaptersFragment.java
View File

@ -93,17 +93,12 @@ public class ChaptersFragment extends Fragment {
} }
@Override @Override
public void onDestroyView() { public void onStop() {
super.onDestroyView(); super.onStop();
if (disposable != null) { if (disposable != null) {
disposable.dispose(); disposable.dispose();
} }
}
@Override
public void onStop() {
super.onStop();
controller.release(); controller.release();
controller = null; controller = null;
EventBus.getDefault().unregister(this); EventBus.getDefault().unregister(this);

13
app/src/main/java/de/danoeh/antennapod/fragment/CoverFragment.java
View File

@ -128,6 +128,10 @@ public class CoverFragment extends Fragment {
@Override @Override
public void onStop() { public void onStop() {
super.onStop(); super.onStop();
if (disposable != null) {
disposable.dispose();
}
controller.release(); controller.release();
controller = null; controller = null;
EventBus.getDefault().unregister(this); EventBus.getDefault().unregister(this);
@ -203,15 +207,6 @@ public class CoverFragment extends Fragment {
} }
} }
@Override
public void onDestroyView() {
super.onDestroyView();
if (disposable != null) {
disposable.dispose();
}
}
void onPlayPause() { void onPlayPause() {
if (controller == null) { if (controller == null) {
return; return;

7
app/src/main/java/de/danoeh/antennapod/fragment/ItemDescriptionFragment.java
View File

@ -66,9 +66,6 @@ public class ItemDescriptionFragment extends Fragment {
public void onDestroy() { public void onDestroy() {
super.onDestroy(); super.onDestroy();
Log.d(TAG, "Fragment destroyed"); Log.d(TAG, "Fragment destroyed");
if (webViewLoader != null) {
webViewLoader.dispose();
}
if (webvDescription != null) { if (webvDescription != null) {
webvDescription.removeAllViews(); webvDescription.removeAllViews();
webvDescription.destroy(); webvDescription.destroy();
@ -168,6 +165,10 @@ public class ItemDescriptionFragment extends Fragment {
@Override @Override
public void onStop() { public void onStop() {
super.onStop(); super.onStop();
if (webViewLoader != null) {
webViewLoader.dispose();
}
controller.release(); controller.release();
controller = null; controller = null;
} }