Castopod
/
AntennaPod
mirror of https://github.com/AntennaPod/AntennaPod.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tweak issue labels and PR template

This commit is contained in:
ByteHamster 2024-02-28 22:45:04 +01:00
parent 7332c04631
commit 33569e8992
4 changed files with 39 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/ISSUE_TEMPLATE/feature_request.yml vendored
View File

@ -1,5 +1,6 @@
name: Feature request name: Feature request
description: Request a new feature or enhancement description: Request a new feature or enhancement
labels: ["Needs: Triage", "Type: Feature request"]
body: body:
- type: checkboxes - type: checkboxes
id: checklist id: checklist

15
.github/pull_request_template.md vendored
View File

@ -1 +1,14 @@
<!-- Please make sure that you have read our contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request --> ### Description
### Checklist
<!--
To help us keep the issue tracker clean and work as efficient as possible,
please make sure that you have done all of the following.
You can tick the boxes below by placing an x inside the brackets like this: [x]
-->
- [ ] I have read the contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [ ] I have performed a self-review of my code
- [ ] My code follows the style guidelines of the AntennaPod project: https://github.com/AntennaPod/AntennaPod/wiki/Code-style
- [ ] I have mentioned the corresponding issue and the relevant keyword (e.g., "Closes: #xy") in the description (see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [ ] If it is a core feature, I have added automated tests

12
.github/workflows/close-if-no-reply.yml vendored
View File

@ -15,13 +15,13 @@ jobs:
with: with:
days-before-stale: 7 days-before-stale: 7
days-before-close: 7 days-before-close: 7
only-labels: 'Awaiting reply' only-labels: 'Needs: Reply'
stale-issue-label: 'Still awaiting reply' stale-issue-label: 'Needs: Reply still'
stale-pr-label: 'Still awaiting reply' stale-pr-label: 'Needs: Reply still'
stale-issue-message: "This issue will be closed when we don't get a reply within 7 days." stale-issue-message: "This issue will be closed when we don't get a reply within 7 days."
stale-pr-message: "This PR will be closed when we don't get a reply within 7 days." stale-pr-message: "This PR will be closed when we don't get a reply within 7 days."
labels-to-remove-when-unstale: 'Awaiting reply' labels-to-remove-when-unstale: 'Needs: Reply'
close-issue-label: "Close reason: no reply" close-issue-label: "Close reason: No reply"
close-pr-label: "Close reason: no reply" close-pr-label: "Close reason: No reply"
close-issue-message: "This issue was closed because we didn't get a reply for 14 days." close-issue-message: "This issue was closed because we didn't get a reply for 14 days."
close-pr-message: "This PR was closed because we didn't get a reply for 14 days." close-pr-message: "This PR was closed because we didn't get a reply for 14 days."

27
CONTRIBUTING.md
View File

@ -28,15 +28,24 @@ If you would like to translate the app into another language or improve an exist
Submit a pull request Submit a pull request
--------------------- ---------------------
- If you want to work on a feature that has been requested or fix a bug that has been reported on the "issues" page, add a comment to it so that other people know that you are working on it. - Before you work on the code
- Fork the repository. - Make sure that there is an issue *without* the `Needs: Triage` or `Needs: Decision` label for the feature you want to implement or bug you want to fix.
- Almost all changes of AntennaPod are done on the `develop` branch. If a new version of AntennaPod is released, the `develop` branch is merged into `master`. As a result, the `master` branch probably doesn't contain the latest changes when you are reading this. Please make sure that you are branching from `develop`! Otherwise, there might be a lot of merge-conflicts when merging your changes into `develop` and therefore it might take longer to review your pull-request. Exceptions are urgent issues that need to be fixed in the production version. - Add a comment to the issue so that other people know that you are working on it.
- If your pull request fixes a bug that has been reported or implements a feature that has been requested in another issue, try to mention it in the message, so that it can be closed once your pull request has been merged. If you use special keywords in the [commit comment](https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) or [pull request text](https://github.blog/2013-05-14-closing-issues-via-pull-requests/), GitHub will close the issue(s) automatically. - You don't need to ask for permission to work on something, just indicate that you are doing so.
- If possible, add unit tests for your pull request and make sure that they pass. - If you want to discuss the approach to take, feel free to ask in the issue or join a [community call](https://antennapod.org/events/community-meeting).
- Please do not upgrade dependencies or build tools unless you have a good reason for it. Doing so can easily introduce bugs that are hard to track down. - Fork the repository
- If you plan to do a change that touches many files (10+), please ask beforehand. This usually causes merge conflicts for other developers. - Create a new branch for your contribution
- Please follow our code style. You can use Checkstyle within Android Studio using our [configuration file](https://github.com/AntennaPod/AntennaPod/blob/develop/config/checkstyle/checkstyle-new-code.xml). - This makes opening possible additional pull requests easier.
- Please only change the English string resources. Translations are handled on [Transifex](https://www.transifex.com/antennapod/antennapod/). - As a base, use the `develop` branch.
- Almost all changes of AntennaPod are done on the `develop` branch. If a new version of AntennaPod is released, the `develop` branch is merged into `master`. As a result, the `master` branch probably doesn't contain the latest changes when you are reading this. Otherwise, there might be a lot of merge-conflicts when merging your changes into `develop` and therefore it might take longer to review your pull-request.
- Get coding :)
- If possible, add unit tests for your pull request and make sure that they pass.
- Please do not upgrade dependencies or build tools unless you have a good reason for it. Doing so can easily introduce bugs that are hard to track down.
- Please follow our code style. You can use Checkstyle within Android Studio using our [configuration file](https://github.com/AntennaPod/AntennaPod/blob/develop/config/checkstyle/checkstyle-new-code.xml).
- Please only change the English string resources. Translations are handled on [Transifex](https://www.transifex.com/antennapod/antennapod/).
- Open the PR
- Mention the corresponding issue in the pull request text, so that it can be closed once your pull request has been merged. If you use [special keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue), GitHub will close the issue(s) automatically.
Building From Source Building From Source
-------------------------- --------------------------