From 21ca881572dfda73b4513821be48fbef7f5d92e9 Mon Sep 17 00:00:00 2001 From: Martin Fietz Date: Wed, 29 Apr 2015 13:28:56 +0200 Subject: [PATCH 1/2] Change icon for failed download(s) report --- .../antennapod/core/service/download/DownloadService.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java index d5f17c099..6703913cc 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java +++ b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java @@ -520,9 +520,7 @@ public class DownloadService extends Service { /** * Creates a notification at the end of the service lifecycle to notify the * user about the number of completed downloads. A report will only be - * created if the number of successfully downloaded feeds is bigger than 1 - * or if there is at least one failed download which is not an image or if - * there is at least one downloaded media file. + * created if there is at least one failed download excluding images */ private void updateReport() { // check if report should be created @@ -556,10 +554,10 @@ public class DownloadService extends Service { getString(R.string.download_report_content), successfulDownloads, failedDownloads) ) - .setSmallIcon(R.drawable.stat_notify_sync) + .setSmallIcon(R.drawable.stat_notify_sync_error) .setLargeIcon( BitmapFactory.decodeResource(getResources(), - R.drawable.stat_notify_sync) + R.drawable.stat_notify_sync_error) ) .setContentIntent( ClientConfig.downloadServiceCallbacks.getReportNotificationContentIntent(this) From fd49d491b72b9261b4ebe3957955c194046f6c32 Mon Sep 17 00:00:00 2001 From: Martin Fietz Date: Wed, 29 Apr 2015 13:49:08 +0200 Subject: [PATCH 2/2] Changed download report icon, ticker and content title --- .../antennapod/core/service/download/DownloadService.java | 4 ++-- core/src/main/res/values/strings.xml | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java index 6703913cc..b3381b4e3 100644 --- a/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java +++ b/core/src/main/java/de/danoeh/antennapod/core/service/download/DownloadService.java @@ -520,7 +520,7 @@ public class DownloadService extends Service { /** * Creates a notification at the end of the service lifecycle to notify the * user about the number of completed downloads. A report will only be - * created if there is at least one failed download excluding images + * created if there is at least one failed download excluding images */ private void updateReport() { // check if report should be created @@ -548,7 +548,7 @@ public class DownloadService extends Service { .setTicker( getString(R.string.download_report_title)) .setContentTitle( - getString(R.string.download_report_title)) + getString(R.string.download_report_content_title)) .setContentText( String.format( getString(R.string.download_report_content), diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml index f162bb353..c0c2f06de 100644 --- a/core/src/main/res/values/strings.xml +++ b/core/src/main/res/values/strings.xml @@ -128,7 +128,8 @@ Authentication error Cancel all downloads Download cancelled - Downloads completed + Downloads completed with error(s) + Download report Malformed URL IO Error Request error