Castopod
/
AntennaPod
mirror of https://github.com/AntennaPod/AntennaPod.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3709 from ByteHamster/fix-feed-update-crash 

Fixed ArrayIndexOutOfBoundsException when updating feeds
This commit is contained in:
H. Lehmann 2019-12-31 13:53:04 +01:00 committed by GitHub
parent 912d2cecee d8a1744cd8
commit 0b5bd94ab6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/src/main/java/de/danoeh/antennapod/core/storage/DBTasks.java
View File

@ -496,17 +496,22 @@ public final class DBTasks {
// item is new // item is new
item.setFeed(savedFeed); item.setFeed(savedFeed);
item.setAutoDownload(savedFeed.getPreferences().getAutoDownload()); item.setAutoDownload(savedFeed.getPreferences().getAutoDownload());
savedFeed.getItems().add(idx, item);
if (idx >= savedFeed.getItems().size()) {
savedFeed.getItems().add(item);
} else {
savedFeed.getItems().add(idx, item);
}
// only mark the item new if it was published after or at the same time // only mark the item new if it was published after or at the same time
// as the most recent item // as the most recent item
// (if the most recent date is null then we can assume there are no items // (if the most recent date is null then we can assume there are no items
// and this is the first, hence 'new') // and this is the first, hence 'new')
if (priorMostRecentDate == null || if (priorMostRecentDate == null
priorMostRecentDate.before(item.getPubDate()) || || priorMostRecentDate.before(item.getPubDate())
priorMostRecentDate.equals(item.getPubDate())) { || priorMostRecentDate.equals(item.getPubDate())) {
Log.d(TAG, "Marking item published on " + item.getPubDate() + Log.d(TAG, "Marking item published on " + item.getPubDate()
" new, prior most recent date = " + priorMostRecentDate); + " new, prior most recent date = " + priorMostRecentDate);
item.setNew(); item.setNew();
} }
} else { } else {