From d61745be86427c2eabad64c81bf9597cb9aa6dd1 Mon Sep 17 00:00:00 2001 From: ByteHamster Date: Sun, 6 Nov 2022 11:55:20 +0100 Subject: [PATCH] Check Lint recursively from the :app module instead of checking every module individually. This avoids having to re-state all disabled Lint checks in all parent modules. --- .github/workflows/checks.yml | 4 ++-- net/discovery/build.gradle | 5 ----- parser/feed/build.gradle | 6 ------ ui/glide/build.gradle | 9 --------- ui/statistics/build.gradle | 7 ------- 5 files changed, 2 insertions(+), 29 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 96de69a1f..57425126a 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -57,8 +57,8 @@ jobs: ~/.gradle/caches ~/.gradle/wrapper key: gradle-${{ hashFiles('**/*.gradle*') }}-${{ hashFiles('**/gradle/wrapper/gradle-wrapper.properties') }} - - name: Lint - run: ./gradlew lintPlayRelease lintRelease + - name: Lint :app module recursively + run: ./gradlew :app:lintPlayRelease - name: SpotBugs run: ./gradlew spotbugsPlayDebug spotbugsDebug 2>&1 | grep -i "spotbugs" diff --git a/net/discovery/build.gradle b/net/discovery/build.gradle index 4bebbd04d..43ec26857 100644 --- a/net/discovery/build.gradle +++ b/net/discovery/build.gradle @@ -14,11 +14,6 @@ android { buildConfigField "String", "PODCASTINDEX_API_SECRET", '"XAaAhk4^2YBsTE33vdbwbZNj82ZRLABDDqFdKe7x"' } } - - lintOptions { - disable 'InvalidPeriodicWorkRequestInterval', 'MissingPermission', - 'GradleCompatible', 'AppCompatResource', 'QueryPermissionsNeeded' - } } dependencies { diff --git a/parser/feed/build.gradle b/parser/feed/build.gradle index 56b4ff740..faabe662c 100644 --- a/parser/feed/build.gradle +++ b/parser/feed/build.gradle @@ -3,12 +3,6 @@ plugins { } apply from: "../../common.gradle" -android { - lintOptions { - disable "TrustAllX509TrustManager" - } -} - dependencies { implementation project(':model') diff --git a/ui/glide/build.gradle b/ui/glide/build.gradle index ff61fc8e1..020a4db8e 100644 --- a/ui/glide/build.gradle +++ b/ui/glide/build.gradle @@ -4,15 +4,6 @@ plugins { apply from: "../../common.gradle" apply from: "../../playFlavor.gradle" -android { - lintOptions { - disable "InvalidPeriodicWorkRequestInterval", "ObsoleteLintCustomCheck", "DefaultLocale", "UnusedAttribute", - "ParcelClassLoader", "CheckResult", "TrustAllX509TrustManager", - "StaticFieldLeak", "IconDensities", "IconDuplicates", "MissingPermission", "AppCompatResource", - "GradleCompatible", "QueryPermissionsNeeded" - } -} - dependencies { implementation project(":model") implementation project(":core") diff --git a/ui/statistics/build.gradle b/ui/statistics/build.gradle index 99c613b75..346fff253 100644 --- a/ui/statistics/build.gradle +++ b/ui/statistics/build.gradle @@ -4,13 +4,6 @@ plugins { apply from: "../../common.gradle" apply from: "../../playFlavor.gradle" -android { - lintOptions { - disable "InvalidPeriodicWorkRequestInterval", "MissingPermission", "GradleCompatible", - "QueryPermissionsNeeded", "Overdraw", "SetTextI18n", "RtlHardcoded" - } -} - dependencies { implementation project(":core") implementation project(":event")